Open
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502
This PR updates the error message shown when pasting or entering unrecognized data to match the iOS behavior. Previously, Android showed "Decoding Error" / "Unable To Interpret Provided Data" while iOS shows "Unable To Read QR" / "Bitkit is not able to read this QR code."
Description
Changes the toast message for unhandled scan data in
AppViewModelfromother__scan_err_decoding/other__scan_err_interpret_titletoother__qr_error_header/other__qr_error_text, aligning Android with iOS parity.Preview
Screen_recording_20260203_135846.webm
QA Notes
1. Paste invalid data
2. Enter invalid data manually
3. Regression - Valid inputs still work